[FSSDK-11142] Add cmab client and tests #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
changed the title
Mat001
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new CMAB client with an integrated exponential backoff retry mechanism and unit tests for decision fetching from the CMAB API.
- Introduces the DefaultCmabClient with retry configuration and error handling
- Implements request marshalling, API response validation, and logging for retries
Comment on lines
+166
to
+167
| // Create context for cancellation | ||
| ctx := context.Background() |
There was a problem hiding this comment.
Consider accepting a context parameter in FetchDecision (or using the context passed from a higher layer) instead of always using context.Background(). This change would allow for better cancellation and deadline management in production use.
Suggested change
| // Create context for cancellation | |
| ctx := context.Background() | |
| // Use the provided context for cancellation |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMAB client and unit tests.
https://jira.sso.episerver.net/browse/FSSDK-11142